Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move predict config update from model loading to config validation #163

Merged
merged 8 commits into from
Dec 18, 2024

Conversation

francoishernandez
Copy link
Member

Previously we had no choice than wait for the checkpoint to be loaded to grab its config, because everything was nested within a single .pt picke file.

Now that everything is nicely split in a directory structure, with directly accessible configuration files, we can move some of this logic to the config validation methods.

This brings two benefits:

  • centralize more and more logic within config validation instead of it being scattered across the framework;
  • grab the proper config sooner in the execution, preventing some unwanted behaviours.

@francoishernandez francoishernandez marked this pull request as ready for review December 18, 2024 17:23
@francoishernandez francoishernandez merged commit 7a0fd50 into main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant