-
Notifications
You must be signed in to change notification settings - Fork 67
No auto-shrink for the sidebar #103
Comments
The sidebar has a hardcoded min-width and I don't think it can be changed by the HTML page that is displayed, so I will most probably end up being a WONTFIX. |
I guess the other option is to ask for an API for this? Mozilla is willing to provide sidebar APIs, which encourages usages that leave the sidebar open all the time. Maybe Mozilla would consider some sort of auto-shrink API or some sort of resize API? Is it worth adding this to the list of API suggestions this extension is provoking? |
Made an #tabbrowser-tabs {
visibility: collapse !important;
}
#sidebar-box {
overflow-x: hidden;
min-width: 50px !important;
max-width: 50px !important;
transition: all 0.25s ease !important;
}
#sidebar-box:hover {
min-width: 250px !important;
max-width: 250px !important;
} Or if you want the sidebar to adapt to your screen width you can use the #sidebar-box {
overflow-x: hidden;
min-width: 15vw !important;
max-width: 15vw !important;
} |
I set it to adapt to my screen with |
What you're asking for, is this: A slightly related bug report is this one: |
FWIW, I've been rolling with the 20wv width for the past week or so, and I love it. If I'm on my mega monitor, it's great. If I'm on my laptop it's great. Seems like having the width adapt like this could be a nice way forward (though we'd want to ensure it could still be adjusted manually). |
@Bo-Duke, cool, thanks. It is pretty close, but it doesn't float above tab content as in original Tab Center, forcing content width change, which is slow and ugly 😬 So here is a floating version, should be even smoother than original, but it has one downside: you need to manually adjust panel height (see comment in CSS). |
For some weird reason, a few windows with a lot of tabs fail to display an overflow vertical scrollbar. I can use the keyboard to blindly switch to tabs at the bottom of the window, so I know they're there. Any thoughts on why some windows sidebars might misbehave like this? |
@shvchk I am really nitpicking at this point, but it seems that the sidebar border-right color is different (not equal to |
While pinned tabs being outside of scrolling container are awesome, for old Tab Center-like configurations with autoshrinking sidebar the presentation of many tabs in one row is actually an antifeature. This PR makes it configurable, so custom userChrome.css configs like in eoger#103 or eoger#118 that restore old behavior can work properly. Also, the thumbnail reseting has been removed. This fixes a newly introduced issue of unpinned tab not having its thumbnail updated. While this could be fixed in other way, disabling thumbnail generation for pinned tabs is not desired when compact pins are disabled anyway.
@ksesong it's |
Can't do much here on my side, but feel free to check the CSS Tweaks wiki page where something similar can be done. |
Is it just me or sidebar auto-hide does not work in the release version of Firefox (Fx70 and Fx71)? It totally works on Nightly channel for me, but not on release. I have redone the CSS file entirely and copied the last version of the CSS from @shvchk. Also switched all the mandatory prefs needed. Everything else works but not the auto hide. Mine is always fixed and I can only resize it manually. |
This is odd, I've managed to make it work by copying the Nightly css file intro Release Chrome folder. I'm not sure if it was something related to the file or the css example provided by @shvchk is missing something to make it work. Using this right now as css:
|
I’m also having problems with the recently released FF71. For me, the sidebar shrinks and expands, but not fixed over the page anymore, instead the page is narrowed and reflowed. Which were the css-files from nightly you copied @SoftVision-PaulOiegas? The white margin you see should be from this rule:
Maybe removing that works? |
Thanks @andersjohansson, indeed it fixed my white margin issue. Somehow I totally overlooked that part of css. 😄 Also, I do have the same problem as you. The sidebar is not opening above the web page, but instead resizes the webpage. However, I'm not sure if this can be avoided since the sidebar occupies window space when expanded, so the web view narrows, which forces the page content to readjust. |
Great! The thing is that something seems to have changed between FF70 and FF71, because for me, in FF70 the sidebar expanded "above" the page, with no shrinking or reflowing happening. I’ve tried to tweak the |
If it's a pref that changed, you could compare the "about:support" page "Important Modified Preferences" sections from both versions. Maybe something jumps up. 😛 |
I solved it! We just need to add #sidebar-box {
display: block;
overflow: hidden;
min-width: 38px;
max-width: 38px;
position: fixed;
transition: all 0.2s ease;
border-right: 1px solid #ddd;
} Maybe this had something to do with the transition from XUL... But I don’t really know. Some of the stuff I looked at to come up with this: |
Uh, nice, works for me too. However, this needs some adjustment on sidebar size, as it is overlapping some parts of the browser UI now. When I'll have some time I'll throw some dimensions that work for my 22inch screen if anyone is interested. At least you'll know what to update for your screen size. |
Holy guacamole, so many tiny adjustments. Then I had to add a Also, I have adjusted the Hope this helps, you really need to manually tweak them to suite your screen. |
Sounds strange that you need so specific vertical adjustments. For me the following works perfectly, at different sizes of the firefox window. BTW, I use Tabcenter Reborn /* HIDE TABS */
#tabbrowser-tabs {
visibility: collapse !important;
}
/* auto-collapsing sidebar: */
#sidebar-box {
display: block;
overflow: hidden;
min-width: 38px;
max-width: 38px;
position: fixed;
transition: all 0.2s ease;
border-right: 1px solid #ddd;
}
#sidebar-box:hover,
#sidebar-header,
#sidebar {
min-width: 20vw !important;
max-width: 20vw !important;
}
#sidebar-header,
#sidebar-splitter {
display: none;
}
/*
* ADJUST!
* I only have the nav-bar, and in compact mode. That's 29px. Tabbar and bookmark bar is hidden.
*/
#sidebar {
height: calc(100vh - 29px);
}
#sidebar-box:not([hidden]) ~ #appcontent {
margin-left: 38px;
}
#main-window[inFullscreen][inDOMFullscreen] #appcontent {
margin-left: 0;
}
#main-window[inFullscreen] #sidebar {
height: 100vh;
} |
Probably I over complicated my CSS, your variant is more cleaner and works better. Thanks for it! |
I've updated my gist to support Firefox 71. It now also uses flexbox, so we don't need to take sidebar header into account when calculating sidebar height, only navbar and bookmarks bar (if any). Also flexbox gives an option to easily place sidebar header at the bottom in case someone wants it.
|
With Firefox 72, the autoshrink that I had (from https://github.com/eoger/tabcenter-redux/wiki/Custom-CSS-tweaks#floating-auto-shrinking-sidebar-103-video-preview ) is broken: the sidebar expands only when I click on a previously unloaded tab, and get skrinked as soon as the page has refreshed/redrawn. If I simply move the mouse over, or click on a loaded tab, the sidebar does not expand. |
I'm using @andersjohansson's version and adding |
@rtrbt : That works, thank you very much! |
Sadly it seems that this CSS breaks each time Firefox updates... Starting to hate this. |
Hello, |
The same for me! Auto-shrink stopped to work on 107 version. |
Tab Center Redux isn't in active development anymore as I don't have time to maintain it. I suggest using an alternative such as Sidebery |
This is a super important feature for me because I use two monitors. My laptop monitor is small and needs to have the sidebar shrunk so that webpages look at all reasonable. My main monitor is huge, so it's silly to have the sidebar shrunk.
Tabcenter had a button for this, but I've always thought it could be algorithmic, based on the size of the window.
In any case, can we have something back?
The text was updated successfully, but these errors were encountered: