Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML readme #413

Merged
merged 3 commits into from
Jul 10, 2023
Merged

YAML readme #413

merged 3 commits into from
Jul 10, 2023

Conversation

h1alexbel
Copy link
Member

@h1alexbel h1alexbel commented Jul 10, 2023

closes #411


PR-Codex overview

This PR adds copyright information and YAML support for creating Kafka producers and consumers. It also updates the README.md file with new API usage examples.

Detailed summary

  • Adds copyright information to producer.yaml and consumer.yaml files
  • Adds YAML support for creating Kafka producers and consumers
  • Updates README.md file with new API usage examples

The following files were skipped due to too many changes: README.md

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

h1alexbel added 2 commits July 10, 2023 10:35
@zoeself
Copy link
Collaborator

zoeself commented Jul 10, 2023

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5fe9022) 98.98% compared to head (f0cd314) 98.98%.

❗ Current head f0cd314 differs from pull request most recent head 316774a. Consider uploading reports for the commit 316774a to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #413   +/-   ##
=========================================
  Coverage     98.98%   98.98%           
  Complexity      169      169           
=========================================
  Files            82       82           
  Lines           494      494           
  Branches          1        1           
=========================================
  Hits            489      489           
  Misses            5        5           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zoeself
Copy link
Collaborator

zoeself commented Jul 10, 2023

@h1alexbel please review this Pull Request. Deadline (when it should be merged or closed) is 2023-07-13T07:39:05.528706.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@h1alexbel
Copy link
Member Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jul 10, 2023

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 316774a into master Jul 10, 2023
@rultor
Copy link
Collaborator

rultor commented Jul 10, 2023

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 2min)

@zoeself
Copy link
Collaborator

zoeself commented Jul 10, 2023

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YAML readme
3 participants