Remove module field from package.json
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Mar 16, 2020
gaearon
approved these changes
Mar 16, 2020
There was a problem hiding this comment.
While technically this is breaking, the usage is super low and is probably mostly React CI builds at this point. Also, there isn't much reason to ESM-import a shallow renderer these days. It's not likely to be used in Rollup setups. So I think this is fine to do now (but not later).
See facebook/react#18187 for context.
ljharb
reviewed
Mar 18, 2020
| @@ -3,7 +3,6 @@ | |||
| "version": "16.13.0", | |||
| "description": "React package for shallow rendering.", | |||
| "main": "index.js", | |||
| "module": "esm/index.js", | |||
There was a problem hiding this comment.
this field is nonstandard anyways and shouldn't ever be used; ESM should be shipped via the "exports" field, since that's what all bundlers have to support already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See facebook/react#18187 for context.
@gaearon has suggested via Twitter DM to stop publishing ESM until there's a better story around it.