Ensure the right versions of React / adapters are installed #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons of React / adapters are installed
ahuth
commented
May 6, 2019
| import semver from 'semver'; | ||
|
|
||
| export default function getAdapterForReactVersion(reactVersion) { | ||
| const normalizedVersion = semver.coerce(reactVersion); |
There was a problem hiding this comment.
Need this because something like "16.3" isn't a valid version, per semver.
Their docs state that coerce is guaranteed to generate a version as long as there is a number in the string.
ahuth
commented
May 6, 2019
| @@ -0,0 +1,86 @@ | |||
| import { expect } from 'chai'; | |||
| import getAdapterForReactVersion from '../../enzyme-adapter-react-helper/src/getAdapterForReactVersion'; | |||
There was a problem hiding this comment.
Feel like I should've been able to do
import getAdapterForReactVersion from 'enzyme-adapter-react-helper/src/getAdapterForReactVersion';
Didn't work, though 🤔
There was a problem hiding this comment.
i think if you add enzyme-adapter-react-helper as a dev dep of enzyme-test-suite, that this will work?
There was a problem hiding this comment.
Oh, that would make sense
ljharb
reviewed
May 6, 2019
| return 'enzyme-adapter-react-13'; | ||
| } | ||
|
|
||
| return 'enzyme-adapter-react-16'; |
There was a problem hiding this comment.
we didn't used to have this fallback here - should it throw instead?
There was a problem hiding this comment.
Yeah, that's probably better than randomly getting the -16 adapter
ljharb
added a commit
that referenced
this pull request
May 8, 2019
- [fix] `install`: Ensure the right versions of React / adapters are installed (#2116) - [dev deps] update `eslint`, `semver`, `rimraf`, `eslint-plugin-react`, `eslint-plugin-import` - [build] include source maps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a weird issue where partial React versions can result in the wrong versions of React being installed. This happens because
semver.intersectsis returning something weird when both are true:See this truth table which highlights the issue.
In this PR we:
semver.satisfiesfromsemver.intersects@ljharb , what do you think?