Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enzyme crash since Cheerio 1.0.0-rc.11 release #2559

Closed
lyz810 opened this issue May 22, 2022 · 5 comments
Closed

enzyme crash since Cheerio 1.0.0-rc.11 release #2559

lyz810 opened this issue May 22, 2022 · 5 comments

Comments

@lyz810
Copy link

lyz810 commented May 22, 2022

https://registry.npmjs.org/enzyme/3.11.0

version of cheerio: ^1.0.0-rc.3 will auto install the lastest version 1.0.0-rc.11, it will cause enzyme crash

In the source code(https://github.com/enzymejs/enzyme/blob/master/packages/enzyme/package.json#L42), the package.json declare version of cheerio is =1.0.0-rc3, but I think this version is not release yet.

So, please update the npm package to make the version declaration valid

@ljharb
Copy link
Member

ljharb commented May 22, 2022

Duplicate of #2558.

enzyme breaks with every version of cheerio after v1.0.0-rc.3, and the next release of enzyme will pin it. In the meantime, you can solve it by adding a dev dependency of cheerio set to =1.0.0-rc.3.

@ljharb ljharb closed this as completed May 22, 2022
@lyz810
Copy link
Author

lyz810 commented May 22, 2022

Duplicate of #2558.

enzyme breaks with every version of cheerio after v1.0.0-rc.3, and the next release of enzyme will pin it. In the meantime, you can solve it by adding a dev dependency of cheerio set to =1.0.0-rc.3.

Could you let us know the plan of next release timeline

@ljharb
Copy link
Member

ljharb commented May 22, 2022

There's no planned release date.

This is a trivially solvable problem in the meantime, so it's not particularly pressing.

@lyz810
Copy link
Author

lyz810 commented May 22, 2022

Any one who is first install enzyme will meet this issue.
I suggest you to add an announcement or pin this issue, to let them know the temporary solution.

@1765659645
Copy link

I encountered a memory overflow problem when running unit tests. After two days of investigation, it was found that it was caused by the upgrade of cheerio to 1.0.0-rc.11

sergio-quintero added a commit to armory-io/deck that referenced this issue Nov 29, 2022
We noticed our deck builds started to fail and found out the following:

PR spinnaker#9875 upgraded `enzyme` and `cheerio` is a transitive dependency that was pinned to `cheerio:=1.0.0-rc6`. As per enzymejs/enzyme#2559 (comment), `enzyme` is not compatible with anything above `cheerio:=1.0.0-rc3` so we should downgrade and keep the pin to avoid any issues.
sergio-quintero added a commit to armory-io/deck that referenced this issue Nov 29, 2022
We noticed our deck builds started to fail and found out the following:

PR spinnaker#9875 upgraded `enzyme` and `cheerio` is a transitive dependency that was pinned to `cheerio:=1.0.0-rc6`. As per enzymejs/enzyme#2559 (comment), `enzyme` is not compatible with anything above `cheerio:=1.0.0-rc3` so we should downgrade and keep the pin to avoid any issues.
mergify bot pushed a commit to spinnaker/deck that referenced this issue Nov 30, 2022
We noticed our deck builds started to fail and found out the following:

PR #9875 upgraded `enzyme` and `cheerio` is a transitive dependency that was pinned to `cheerio:=1.0.0-rc6`. As per enzymejs/enzyme#2559 (comment), `enzyme` is not compatible with anything above `cheerio:=1.0.0-rc3` so we should downgrade and keep the pin to avoid any issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants