Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 4 support #1182

Closed
pascalduez opened this issue Sep 27, 2017 · 3 comments
Closed

Node 4 support #1182

pascalduez opened this issue Sep 27, 2017 · 3 comments

Comments

@pascalduez
Copy link

pascalduez commented Sep 27, 2017

Hi,

there's no mention in the docs nor migration guide that enzyme >= 3 dropped support for Node 4.
However, since rst-selector-parser has such restriction, installs fails on Node 4.

@ljharb
Copy link
Member

ljharb commented Sep 28, 2017

In that case, that's an issue in rst-selector-parser; but engines is merely advisory. Why would that make installation fail?

@pascalduez
Copy link
Author

Why would that make installation fail?

It seems to be failing on the CI, with Yarn.
https://travis-ci.org/pascalduez/react-module-boilerplate/jobs/280622034

@ljharb
Copy link
Member

ljharb commented Sep 28, 2017

That's due to a poor decision yarn made; npm proper doesn't fail when "engines" isn't met. I'd suggest using npm instead.

Either way, I've filed aweary/rst-selector-parser#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants