Drop node 4 support

[samit4me]

Currently, it looks like CI builds are failing and I suspect they have been since updating to react 16 in #480.

After looking into this, it turns out enzyme swapped one of their dependencies scapel for rst-selector-parser which only supports node 5 and above. It also seems that node 4 is no longer active according to the node release schedule, so my question is can this repo drop support for node 4?

For further details see comments in #488.

[kwelch]

Here are some note from when i initially looked at this issue.

Further review yarn is also the cause of this. It is failing due to the engines field which is only enforced by yarn. Found in this enzyme issue enzymejs/enzyme#1182

I am not against dropping Node v4, but we should look into supporting Node v7.

[samit4me]

That sounds good, supporting node 8 would be good also it's the next LTS.

You're right yarn throws the error and stops. That seems like a good thing as npm 2.15.11 throws the following:

npm WARN engine [email protected]: wanted: {"node":">=5"} (current: {"node":"4.8.4","npm":"2.15.11"})

Then what feels like 2 hours later:

npm ERR! Darwin 16.7.0
npm ERR! argv "/Users/sam/.nvm/versions/node/v4.8.4/bin/node" "/Users/sam/.nvm/versions/node/v4.8.4/bin/npm" "i"
npm ERR! node v4.8.4
npm ERR! npm  v2.15.11
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package [email protected] does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants react@^16.0.0-beta.5
npm ERR! peerinvalid Peer [email protected] wants react@^0.14.0 || ^15.0.0-0 || ^16.0.0-0
npm ERR! peerinvalid Peer [email protected] wants react@>=15
npm ERR! peerinvalid Peer [email protected] wants react@^15
npm ERR! peerinvalid Peer [email protected] wants react@^16.0.0-0
npm ERR! peerinvalid Peer [email protected] wants react@^16.0.0-beta.5

[samit4me]

Looks like there might be a fix for this soon, see enzymejs/enzyme#1285

[nickytonline]

I'm down with dropping node 4. ❎

[nickytonline]

It looks like enzymejs/enzyme#1285 is sorted out. Are we all OK to drop Node 4 support?

[coryhouse]

I'm okay w/ it if we must, but I'm unclear. The last comment in the thread you linked says the Enzyme CI actually runs Node 4 too. Where did you read that they don't support Node 4?

[nickytonline]

I must have misread. In that case, ignore my last comment.

[samit4me]

Closing this issue as the problem with node 4 was resolved upstream in rst-selector-parser.