Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] breaks build 🚨 #118

Closed
wants to merge 1 commit into from

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello lovely humans,

enzyme just published its new version 2.5.0.

State Failing tests 🚨
Dependency enzyme
New version 2.5.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build went from success to failure.

As enzyme is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


The new version differs by 346 commits .

  • e0ac400 v2.5.0
  • 8b10257 Merge pull request #629 from baldwmic/patch-1
  • 4fb65cb Update hasClass.md
  • 2a357f4 Update hasClass.md
  • 19d06e8 fixes #590: change isCompoundSelector to not match prop selector
  • 58764f1 [Docs] fix typo in ShallowWrapper/render.md
  • c1e03cc Use callback instead of cb
  • 0e7c4d5 Use batchedUpdates for setProps test
  • 799c0d7 Add test for cb error if not function
  • 0b424bd Default cb to undefined so it doesn't count toward functions length
  • 0d6b8b4 Add tests
  • 9b5a476 Add callback to setProps and setState
  • f3a91e3 Update docs
  • 746eac4 Merge pull request #594 from Aweary/iterable-wrapper
  • 5b9022a Only test iterable when Symbol.iterator exists

There are 250 commits in total. See the full diff.


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? ⚡ greenkeeper upgrade

@lelandrichardson
Copy link

Do you all have any idea why this is failing? I can't seem to track it down.

Failure seems to happen on this:
https://github.com/producthunt/chai-enzyme/blob/master/src/ReactTestWrapper.js#L13

And internally in enzyme on:
https://github.com/airbnb/enzyme/blob/master/src/ReactWrapper.jsx#L855

I'm not sure why. It seems to think (n) => findDomNode(n) is undefined?

cc @ljharb @aweary @ayrton

@lelandrichardson
Copy link

nvm. we figured it out. fix incoming.

@ljharb
Copy link
Member

ljharb commented Oct 17, 2016

I think that's my bad - I changed the signature of single, not realizing that'd be a breaking change.

@ljharb
Copy link
Member

ljharb commented Oct 17, 2016

Fix PR up enzymejs/enzyme#632

@ayrton
Copy link
Contributor

ayrton commented Oct 17, 2016

@lelandrichardson @ljharb awesome job guys 💯

@ayrton ayrton deleted the greenkeeper-enzyme-2.5.0 branch October 17, 2016 19:16
@lelandrichardson
Copy link

...aaaaand 2.5.1 is out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants