Bisect test_gcc CI test

.azure-pipelines/pipelines.yml

@@ -4,115 +4,16 @@ trigger:
     - "main"
 
 stages:
-- stage: check
-  dependsOn: []
+- stage: test_gcc
   pool: "x64-large"
   jobs:
-  - job: build_and_format
-    displayName: "do_ci.sh"
-    dependsOn: []
-    strategy:
-      maxParallel: 2
-      matrix:
-        build:
-          CI_TARGET: "build"
-        format:
-          CI_TARGET: "check_format"
-    timeoutInMinutes: 120
-    steps:
-    - template: bazel.yml
-      parameters:
-        ciTarget: $(CI_TARGET)
-
-- stage: test
-  dependsOn: ["check"]
-  pool: "x64-large"
-  jobs:
-  - job: test_and_benchmark
-    displayName: "do_ci.sh"
-    strategy:
-      # Both test and benchmark need dedicated resources for stability.
-      maxParallel: 1
-      matrix:
-        test:
-          CI_TARGET: "test"
-        benchmark:
-          CI_TARGET: "benchmark_with_own_binaries"
-    timeoutInMinutes: 120
-    steps:
-    - template: bazel.yml
-      parameters:
-        ciTarget: $(CI_TARGET)
-
-- stage: clang_tidy
-  dependsOn: ["check"]
-  pool: "x64-large"
-  jobs:
-  - job: clang_tidy
+  - job: test_gcc
     displayName: "do_ci.sh"
     strategy:
       maxParallel: 1
       matrix:
-        clang_tidy:
-          CI_TARGET: "clang_tidy"
-    timeoutInMinutes: 120
-    steps:
-    - template: bazel.yml
-      parameters:
-        ciTarget: $(CI_TARGET)
-
-- stage: sanitizers
-  dependsOn: ["test"]
-  pool: "x64-large"
-  jobs:
-  - job: sanitizers
-    displayName: "do_ci.sh"
-    strategy:
-      maxParallel: 2
-      matrix:
-        asan:
-          CI_TARGET: "asan"
-        tsan:
-          CI_TARGET: "tsan"
-    timeoutInMinutes: 120
-    steps:
-    - template: bazel.yml
-      parameters:
-        ciTarget: $(CI_TARGET)
-
-- stage: coverage
-  dependsOn: ["test"]
-  pool: "x64-large"
-  jobs:
-  - job: coverage
-    displayName: "do_ci.sh"
-    strategy:
-      maxParallel: 2
-      matrix:
-        coverage:
-          CI_TARGET: "coverage"
-        coverage_integration:
-          CI_TARGET: "coverage_integration"
-    timeoutInMinutes: 120
-    steps:
-    - template: bazel.yml
-      parameters:
-        ciTarget: $(CI_TARGET)
-
-- stage: release
-  dependsOn:
-  - "clang_tidy"
-  - "sanitizers"
-  - "coverage"
-  condition: eq(variables['PostSubmit'], true)
-  pool: "x64-large"
-  jobs:
-  - job: release
-    displayName: "do_ci.sh"
-    strategy:
-      matrix:
-        release:
-          CI_TARGET: "docker"
+        test_gcc:
+          CI_TARGET: "test_gcc"
     timeoutInMinutes: 120
     steps:
     - template: bazel.yml

bazel/repositories.bzl

@@ -1,7 +1,7 @@
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
-ENVOY_COMMIT = "0f0f675c22de944889298e0787e107265367b367"
-ENVOY_SHA = "711446e6eedbced802d95e84303b6215e116bc68bfde55d8ab429dad1b9857cd"
+ENVOY_COMMIT = "9b424e6328e72a6f579fb39308786a90431de5aa"
+ENVOY_SHA = "1a8855e046de1d7ab1abab926ac78d6d41b42f8323d0ccddf728367722c34f75"
 
 HDR_HISTOGRAM_C_VERSION = "0.11.2"  # October 12th, 2020
 HDR_HISTOGRAM_C_SHA = "637f28b5f64de2e268131e4e34e6eef0b91cf5ff99167db447d9b2825eae6bad"

source/client/client.cc

@@ -79,6 +79,7 @@ bool Main::run() {
         *options_, dns_resolver_factory, std::move(typed_dns_resolver_config), time_system);
     if (!process_or_status.ok()) {
       ENVOY_LOG(error, "Unable to create ProcessImpl: {}", process_or_status.status().ToString());
+      Envoy::Network::DnsResolverFactory::terminateFactories();
       return false;
     }
     process = std::move(*process_or_status);

source/client/process_impl.cc

@@ -197,8 +197,7 @@ class ClusterManagerFactory : public Envoy::Upstream::ProdClusterManagerFactory
              Envoy::Http::HttpConnPoolImplBase* pool) {
             Envoy::Http::CodecClientPtr codec{new Envoy::Http::CodecClientProd(
                 Envoy::Http::CodecClient::Type::HTTP1, std::move(data.connection_),
-                data.host_description_, pool->dispatcher(), pool->randomGenerator(),
-                pool->transportSocketOptions())};
+                data.host_description_, pool->dispatcher(), pool->randomGenerator())};
             return codec;
           },
           protocols);
@@ -325,6 +324,7 @@ void ProcessImpl::shutdown() {
   }
   tls_.shutdownThread();
   dispatcher_->shutdown();
+  Envoy::Network::DnsResolverFactory::terminateFactories();
   shutdown_ = true;
 }
 

source/client/service_impl.cc

@@ -45,6 +45,7 @@ void ServiceImpl::handleExecutionRequest(const nighthawk::client::ExecutionReque
     response.mutable_error_detail()->set_message(
         fmt::format("Unable to create ProcessImpl: {}", process_or_status.status().ToString()));
     writeResponse(response);
+    Envoy::Network::DnsResolverFactory::terminateFactories();
     return;
   }
   ProcessPtr process = std::move(*process_or_status);

test/python_test.cc

@@ -13,11 +13,14 @@ class PythonTest : public Test {};
 // of getting code coverage reporting to also consider the code hit by integration tests.
 TEST_F(PythonTest, IntegrationTests) {
   const std::string path = TestEnvironment::runfilesPath("test/integration/integration_test");
+  // The binary accepts a python expression it compares all test targets against.
+  // See the k argument in https://docs.pytest.org/en/6.2.x/reference.html#command-line-flags
+  const std::string altered_cmd = path + " test_remote_execution_basics";
 #if defined(__has_feature) && (__has_feature(thread_sanitizer) || __has_feature(address_sanitizer))
   char env[] = "NH_INTEGRATION_TEST_SANITIZER_RUN=1";
   putenv(env);
 #endif
-  ASSERT_EQ(0, system(path.c_str()));
+  ASSERT_EQ(0, system(altered_cmd.c_str()));
 }
 
-} // namespace Nighthawk
+} // namespace Nighthawk