-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor filter configuration to make the different test server filters independent #855
Conversation
Pull latest into my fork
sync to latest
update to master
sync to main
Signed-off-by: Nathan Perry <[email protected]>
Signed-off-by: Nathan Perry <[email protected]>
Signed-off-by: Nathan Perry <[email protected]>
dynamic-delay filter Signed-off-by: Nathan Perry <[email protected]>
Signed-off-by: Nathan Perry <[email protected]>
c73aada
to
f16906d
Compare
Signed-off-by: Nathan Perry <[email protected]>
d7b548a
to
f8df2d6
Compare
Signed-off-by: Nathan Perry <[email protected]>
Signed-off-by: Nathan Perry <[email protected]>
Signed-off-by: Nathan Perry <[email protected]>
@qqustc please review and assign back to me once done. |
Signed-off-by: Nathan Perry <[email protected]>
Signed-off-by: Nathan Perry <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we as part of this PR add a CHANGELOG.md file and document the breaking change? Specifically we should call out (with an example) what broke and how users are expected to modify their configs to make it work again.
Looks like we introduced two breaks, so we should document both:
- A break when we moved onto the
experimental_response_options
fields. - A break where we removed the
experimental_response_options
fields.
Signed-off-by: Nathan Perry <[email protected]>
Signed-off-by: Nathan Perry <[email protected]>
@mum4k Believe I have addressed all your feedback now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the documentation and tags. Sending a round of review on the docs.
Signed-off-by: Nathan Perry <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
This is a followup to #852. In that change, we duplicated ResponseOptions onto separate DynamicDelayConfiguration and TimeTrackingConfiguration protos. However, this resulted in many fields on those protos that were not relevant to each filter. In this PR, we make it so that only the relevant fields exist on each proto.
Resulting changes: