Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Human readable output histogram: 1st column too small #352

Closed
oschaaf opened this issue Jun 9, 2020 · 0 comments · Fixed by #354
Closed

Human readable output histogram: 1st column too small #352

oschaaf opened this issue Jun 9, 2020 · 0 comments · Fixed by #354
Assignees
Labels
bug Something isn't working P1

Comments

@oschaaf
Copy link
Member

oschaaf commented Jun 9, 2020

As can be observed in here, the 99,9... histogram percentile bleeds over into the second column.

I suspect this crept in in a recent Envoy dep update

To resolve we should ideally:

  • Don't rely on any default formatting, which might get updated by dependencies
  • In addition or instead of the above, truncate the percentile precision (0.999 probably would suffice)
  • Figure out how we can make sure this stays put in a test

Thanks to @jmarantz for noticing

@oschaaf oschaaf added the bug Something isn't working label Jun 9, 2020
@oschaaf oschaaf self-assigned this Jun 9, 2020
@oschaaf oschaaf added the P1 label Jun 9, 2020
oschaaf added a commit to oschaaf/nighthawk that referenced this issue Jun 10, 2020
mum4k pushed a commit that referenced this issue Jun 12, 2020
- Cap the number of decimals when rendering the percentiles column data.
- Add a more detailed test for fixating output of the human readable output formatter, so we'll catch unintended changes better next time.

Fixes #352

Signed-off-by: Otto van der Schaaf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant