Review feedback: better target tests

Signed-off-by: Otto van der Schaaf <[email protected]>
envoyproxy · Jun 10, 2020 · 0711c15 · 0711c15
1 parent fac1a1c
commit 0711c15
Show file tree

Hide file tree

Showing 6 changed files with 34 additions and 1,148 deletions.
diff --git a/test/BUILD b/test/BUILD
@@ -99,14 +99,14 @@ envoy_cc_test(
     name = "output_formatter_test",
     srcs = ["output_formatter_test.cc"],
     data = [
-        "test_data/large-sample.json",
         "test_data/output_formatter.dotted.gold",
         "test_data/output_formatter.json.gold",
-        "test_data/output_formatter.large.txt.gold",
         "test_data/output_formatter.medium.fortio.gold",
         "test_data/output_formatter.medium.proto.gold",
         "test_data/output_formatter.txt.gold",
         "test_data/output_formatter.yaml.gold",
+        "test_data/percentile-column-overflow.json",
+        "test_data/percentile-column-overflow.txt.gold",
     ],
     repository = "@envoy",
     deps = [

diff --git a/test/output_formatter_test.cc b/test/output_formatter_test.cc
@@ -193,10 +193,10 @@ TEST_F(MediumOutputCollectorTest, FortioFormatter) {
 }
 
 TEST_F(MediumOutputCollectorTest, ConsoleOutputFormatter) {
-  const auto input_proto = loadProtoFromFile("test/test_data/large-sample.json");
+  const auto input_proto = loadProtoFromFile("test/test_data/percentile-column-overflow.json");
   ConsoleOutputFormatterImpl formatter;
   expectEqualToGoldFile(formatter.formatProto(input_proto),
-                        "test/test_data/output_formatter.large.txt.gold");
+                        "test/test_data/percentile-column-overflow.txt.gold");
 }
 
 class StatidToNameTest : public Test {};