Bump vtprotobuf import #1026
Open
Bump vtprotobuf import #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhybrillou
force-pushed
the
bump_vtprotobuf
branch
2 times, most recently
from
34c9d3d to
1964be4
Compare
valerian-roche
approved these changes
Oct 26, 2024
|
CI is failing as there seems to be a go 1.22 requirement in the dependency chain |
|
@rhybrillou can you rebase here? The build chain go version got bumped |
rhybrillou
force-pushed
the
bump_vtprotobuf
branch
2 times, most recently
from
275e9c9 to
6e969c0
Compare
|
@alecholmez The branch is rebased. What are the next steps to progress here ? |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Signed-off-by: Yann Brillouet <[email protected]>
rhybrillou
force-pushed
the
bump_vtprotobuf
branch
from
6e969c0 to
db369aa
Compare
|
@valerian-roche @alecholmez The PR was rebased once more. Could you please check that the changes still make sense and re-trigger CI ? Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align the VTProtobuf version with the one in envoyproxy/envoy (envoyproxy/envoy#33413)