Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Lua EnvoyExtensionPolicy #5171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rudrakhp
Copy link
Contributor

What type of PR is this?

feat: implement Lua feature in EnvoyExtensionPolicy

What this PR does / why we need it:
Implement API introduced in #4932

Which issue(s) this PR fixes:

Related #4627

Release Notes: No

@rudrakhp rudrakhp requested a review from a team as a code owner January 28, 2025 18:54
@rudrakhp
Copy link
Contributor Author

@arkodg @zhaohuabing Wanted to get an initial buy in regarding the approach while I add more unit tests and E2E, please do review. Thanks!

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 63.15789% with 63 lines in your changes missing coverage. Please review.

Project coverage is 66.88%. Comparing base (57d4aa8) to head (f8c84b2).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
internal/gatewayapi/envoyextensionpolicy.go 63.88% 23 Missing and 3 partials ⚠️
internal/xds/translator/lua.go 67.21% 13 Missing and 7 partials ⚠️
internal/provider/kubernetes/controller.go 0.00% 13 Missing and 1 partial ⚠️
internal/gatewayapi/luavalidator/lua_validator.go 87.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #5171    +/-   ##
========================================
  Coverage   66.87%   66.88%            
========================================
  Files         210      212     +2     
  Lines       32979    33159   +180     
========================================
+ Hits        22054    22177   +123     
- Misses       9586     9633    +47     
- Partials     1339     1349    +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg
Copy link
Contributor

arkodg commented Jan 28, 2025

hey @rudrakhp the code looks great !

please feel free to continue with unit tests and e2e

@rudrakhp rudrakhp force-pushed the feat_lua_extension branch 16 times, most recently from 304052e to c93397e Compare January 31, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants