validate all xds resources before returning the translation result #5148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
force-pushed
the
fix-5147
branch
2 times, most recently
from
befa1a4 to
4d53353
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5148 +/- ##
==========================================
+ Coverage 66.85% 66.88% +0.03%
==========================================
Files 210 209 -1
Lines 32979 32917 -62
==========================================
- Hits 22047 22018 -29
+ Misses 9592 9573 -19
+ Partials 1340 1326 -14 ☔ View full report in Codecov by Sentry. |
zhaohuabing
force-pushed
the
fix-5147
branch
3 times, most recently
from
6eb31de to
a03807e
Compare
zhaohuabing
commented
Jan 25, 2025
| @@ -131,6 +131,12 @@ func (t *Translator) Translate(xdsIR *ir.Xds) (*types.ResourceVersionTable, erro | |||
| } | |||
| } | |||
|
|
|||
| // Validate all the xds resources in the table before returning | |||
| // This is necessary to catch any misconfigurations that might have been missed during translation | |||
| if err := tCtx.ValidateAll(); err != nil { | |||
There was a problem hiding this comment.
This is the key change, the rest are minor refactors around the proto validation.
zhaohuabing
commented
Jan 25, 2025
| @@ -82,10 +82,7 @@ func buildHCMBasicAuthFilter(basicAuth *ir.BasicAuth) (*hcmv3.HttpFilter, error) | |||
| }, | |||
| }, | |||
| } | |||
| if err = basicAuthProto.ValidateAll(); err != nil { | |||
There was a problem hiding this comment.
Validation in individual filer translators are not required anymore, as they'll be validated inside the proto.ToAnyWithValidation function before converting to any.
zhaohuabing
force-pushed
the
fix-5147
branch
3 times, most recently
from
abd87f7 to
5faed17
Compare
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
|
should we CP to 1.3.0 ? |
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces validation for all generated xDS resources before sending them to the Envoy fleet.
Related to: #5147
Release Notes: No