bump envoyproxy/go-control-plane #5020
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5020 +/- ##
==========================================
- Coverage 66.78% 66.69% -0.09%
==========================================
Files 209 209
Lines 32264 32264
==========================================
- Hits 21547 21520 -27
- Misses 9421 9442 +21
- Partials 1296 1302 +6 ☔ View full report in Codecov by Sentry. |
| // Import all Envoy filter types so they are registered and deserialization does not fail | ||
| // when using them in the "typed_config" attributes. | ||
| package extensions | ||
| // DO NOT REMOVE THE FOLLOWING IMPORTS | ||
| import _ "github.com/envoyproxy/go-control-plane/contrib/envoy/extensions/compression/qatzip/compressor/v3alpha" |
There was a problem hiding this comment.
curious why contrib is needed here
There was a problem hiding this comment.
it's splited from github.com/envoyproxy/go-control-plane by default.
There was a problem hiding this comment.
@zirain and I discussed offline around whether we should include the contrib imports or not.
for now we should since we have docs that link to contrib images https://gateway.envoyproxy.io/docs/tasks/security/private-key-provider/
if image size becomes an issue, we can revisit this in the future
zirain
force-pushed
the
bump-envoy-control-plane
branch
from
1ec5a8f to
736b106
Compare
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
zirain
force-pushed
the
bump-envoy-control-plane
branch
from
736b106 to
e112249
Compare
fixes: #5007