-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/v1.2] release note for v1.2.3 #4820
Conversation
* release note for v1.2.3 Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4820 +/- ##
=======================================
Coverage 65.61% 65.61%
=======================================
Files 211 211
Lines 31999 31999
=======================================
Hits 20995 20995
Misses 9761 9761
Partials 1243 1243 ☔ View full report in Codecov by Sentry. |
@@ -6,8 +6,8 @@ | |||
{{- "v1.1.4" -}} | |||
{{- end -}} | |||
{{- with (strings.HasPrefix $pagePrefix "v1.2") -}} | |||
{{- "v1.2.2" -}} | |||
{{- "v1.2.3" -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be part of another PR, else this will cause the.docs.site to be broken for some duration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a better approach would be publishing the release first, then modify the doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah +1
Signed-off-by: Huabing Zhao <[email protected]>
* [release/v1.2] release note for v1.2.3 (envoyproxy#4813) * release note for v1.2.3 Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> * address comment Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> (cherry picked from commit 81faf42) Signed-off-by: Huabing Zhao <[email protected]>
* [release/v1.2] release note for v1.2.3 (#4820) * [release/v1.2] release note for v1.2.3 (#4813) * release note for v1.2.3 Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> * address comment Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> (cherry picked from commit 81faf42) Signed-off-by: Huabing Zhao <[email protected]> * fix gen check Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]>
…nvoyproxy#4824) * [release/v1.2] release note for v1.2.3 (envoyproxy#4820) * [release/v1.2] release note for v1.2.3 (envoyproxy#4813) * release note for v1.2.3 Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> * address comment Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> (cherry picked from commit 81faf42) Signed-off-by: Huabing Zhao <[email protected]> * fix gen check Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]>
No description provided.