feat: basic auth impl #2224
Merged
feat: basic auth impl #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2224 +/- ##
==========================================
- Coverage 64.49% 64.22% -0.27%
==========================================
Files 111 112 +1
Lines 15482 15668 +186
==========================================
+ Hits 9985 10063 +78
- Misses 4881 4964 +83
- Partials 616 641 +25 ☔ View full report in Codecov by Sentry. |
zhaohuabing
force-pushed
the
basic-auth-impl
branch
from
5542caa to
c4001c3
Compare
|
/retest |
arkodg
reviewed
Nov 22, 2023
arkodg
reviewed
Nov 22, 2023
| return perRouteFilterName(basicAuthFilter, route.Name) | ||
| } | ||
|
|
||
| func basicAuthConfig(route *ir.HTTPRoute) *basicauthv3.BasicAuth { |
There was a problem hiding this comment.
shouldnt we be sending the data via SDS ?
There was a problem hiding this comment.
The password is hashed and the user list is annotated as sensitive data, so it won't be exposed to Envoy config dump.
"http_filters": [
{
"name": "envoy.filters.http.basic_auth",
"typed_config": {
"@type": "type.googleapis.com/envoy.extensions.filters.http.basic_auth.v3.BasicAuth",
"users": {
"inline_string": "[redacted]"
}
}
},
message BasicAuth {
// Username-password pairs used to verify user credentials in the "Authorization" header.
// The value needs to be the htpasswd format.
// Reference to https://httpd.apache.org/docs/2.4/programs/htpasswd.html
config.core.v3.DataSource users = 1 [(udpa.annotations.sensitive) = true];
}
[(udpa.annotations.sensitive) = true] to denote sensitive fields that should be redacted in output such as logging or configuration dumps.
zhaohuabing
force-pushed
the
basic-auth-impl
branch
from
c2b407f to
5b79bbd
Compare
Signed-off-by: huabing zhao <[email protected]> add referenced secrets to resource Signed-off-by: huabing zhao <[email protected]> change string to []byte Signed-off-by: huabing zhao <[email protected]>
zhaohuabing
force-pushed
the
basic-auth-impl
branch
7 times, most recently
from
7574319 to
f8258db
Compare
|
/retest |
zhaohuabing
force-pushed
the
basic-auth-impl
branch
2 times, most recently
from
9d90711 to
ccc69cb
Compare
Signed-off-by: huabing zhao <[email protected]>
zhaohuabing
force-pushed
the
basic-auth-impl
branch
from
ccc69cb to
237b964
Compare
zirain
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #1660
close #2226
@saltbo