Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependabot #1564

Closed
wants to merge 4 commits into from
Closed

chore: update dependabot #1564

wants to merge 4 commits into from

Conversation

zirain
Copy link
Member

@zirain zirain commented Jun 19, 2023

reduce noise, see #1557

Signed-off-by: hejianpeng <[email protected]>
@zirain zirain marked this pull request as ready for review June 19, 2023 09:24
@zirain zirain requested a review from a team as a code owner June 19, 2023 09:24
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #1564 (352e481) into main (f4252e6) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 352e481 differs from pull request most recent head 90717da. Consider uploading reports for the commit 90717da to get more accurate results

@@            Coverage Diff             @@
##             main    #1564      +/-   ##
==========================================
- Coverage   61.87%   61.73%   -0.14%     
==========================================
  Files          81       81              
  Lines       12032    12182     +150     
==========================================
+ Hits         7445     7521      +76     
- Misses       4131     4191      +60     
- Partials      456      470      +14     

see 8 files with indirect coverage changes

@@ -13,6 +13,11 @@ updates:
directory: /
schedule:
interval: weekly
ignore:
# Ignore the following modules as they are updated by k8s.io/kubectl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo, this makes sense if we can prove that all the releases for these modules are ALWAYS triggered together

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we cannot, but in most cases, you don't need to update them immediately after release.

@zirain zirain closed this Jun 28, 2023
@zirain zirain deleted the dependabot branch June 28, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants