Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix win32 breakage 18 dec #9399

Merged
merged 7 commits into from
Dec 20, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Simplify as suggested by zuercher
Signed-off-by: William A Rowe Jr <[email protected]>
  • Loading branch information
wrowe committed Dec 20, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 5baa115e0c2dc0bddb94b1f16b1204c09a7cd1e3
2 changes: 1 addition & 1 deletion test/common/config/metadata_test.cc
Original file line number Diff line number Diff line change
@@ -60,7 +60,7 @@ class TypedMetadataTest : public testing::Test {

struct Bar : public TypedMetadata::Object {};

class FooFactory : public Envoy::Config::TypedMetadataFactory {
class FooFactory : public TypedMetadataFactory {
public:
const std::string name() const override { return "foo"; }
// Throws EnvoyException (conversion failure) if d is empty.