Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: override ALPN in transport socket options #8470

Merged
merged 3 commits into from
Oct 4, 2019
Merged

tls: override ALPN in transport socket options #8470

merged 3 commits into from
Oct 4, 2019

Conversation

yxue
Copy link
Contributor

@yxue yxue commented Oct 3, 2019 •
edited
Loading

Signed-off-by: crazyxy [email protected]

Description: Override ALPN in transport socket options
Risk Level: Low
Testing: Unit test
Docs Changes: N/A
Release Notes: N/A
Fixes #Issue: Part of #8197

@yxue yxue requested a review from lizan as a code owner October 3, 2019 00:28
@lizan lizan self-assigned this Oct 3, 2019
lizan
lizan reviewed Oct 3, 2019
View reviewed changes
Copy link
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I was doing similar thing for upstream SNI override with HTTP so this helps on that too.

test/extensions/transport_sockets/tls/ssl_socket_test.cc Outdated Show resolved Hide resolved
source/common/network/application_protocol.h Outdated Show resolved Hide resolved
source/common/upstream/cluster_manager_impl.cc Outdated Show resolved Hide resolved
@yxue
address comments
cc75b49 
Signed-off-by: crazyxy <[email protected]>
lizan
lizan reviewed Oct 3, 2019
View reviewed changes
Copy link
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo last one comment.

source/extensions/transport_sockets/tls/context_impl.cc Outdated Show resolved Hide resolved
@lizan lizan merged commit f112818 into envoyproxy:master Oct 4, 2019
danzh2010 pushed a commit to danzh2010/envoy that referenced this pull request Oct 4, 2019
@yxue
tls: override ALPN in transport socket options (envoyproxy#8470)
7fc5d4c 
Description: Override ALPN in transport socket options
Risk Level: Low
Testing: Unit test
Docs Changes: N/A
Release Notes: N/A
Fixes #Issue: Part of envoyproxy#8197

Signed-off-by: crazyxy <[email protected]>
@yxue yxue mentioned this pull request Oct 4, 2019
Closed
nandu-vinodan pushed a commit to nandu-vinodan/envoy that referenced this pull request Oct 17, 2019
@yxue @nandu-vinodan
tls: override ALPN in transport socket options (envoyproxy#8470)
27880b4 
Description: Override ALPN in transport socket options
Risk Level: Low
Testing: Unit test
Docs Changes: N/A
Release Notes: N/A
Fixes #Issue: Part of envoyproxy#8197

Signed-off-by: crazyxy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizan lizan lizan approved these changes

Assignees

@lizan lizan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yxue @lizan