-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clang-tidy: check casing on class names #8411
clang-tidy: check casing on class names #8411
Conversation
Signed-off-by: Derek Argueta <[email protected]>
@@ -101,7 +101,7 @@ TEST(Logger, checkLoggerLevel) { | |||
} | |||
}; | |||
|
|||
logTestClass testObj; | |||
LogTestClass testObj; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/testObj/test_obj/ I think you'll catch this in next identifier-naming PR but feel free to fix here too.
I might need to revisit this check another time - clang-tidying This isn't an effect of clang-tidy, just an issue in the build system that seems to have relied on transitive dependencies for getting abseil. |
@derekargueta I think you may add abseil_strings deps to envoy_basic_cc_library, that shouldn't introduce circular dependency. |
Signed-off-by: Derek Argueta <[email protected]>
Signed-off-by: Derek Argueta <[email protected]>
Description: verify `CamelCase` for class names. Risk Level: low Testing: existing Docs Changes: N/A Release Notes: N/A Signed-off-by: Derek Argueta <[email protected]>
Description: verify
CamelCase
for class names.Risk Level: low
Testing: existing
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Derek Argueta [email protected]