Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[headermap] speedup for appending data #8029

Merged
merged 2 commits into from
Aug 25, 2019
Merged

[headermap] speedup for appending data #8029

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba49c29
only validate incoming data to append for invalid characters
asraa Aug 23, 2019
3aa1c0e
move check
asraa Aug 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/common/http/header_map_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ void HeaderString::freeDynamic() {
bool HeaderString::valid() const { return validHeaderString(getStringView()); }

void HeaderString::append(const char* data, uint32_t size) {
ASSERT(validHeaderString(absl::string_view(data, size)));
switch (type_) {
case Type::Reference: {
// Rather than be too clever and optimize this uncommon case, we dynamically
Expand Down Expand Up @@ -148,7 +149,6 @@ void HeaderString::append(const char* data, uint32_t size) {

memcpy(buffer_.dynamic_ + string_length_, data, size);
string_length_ += size;
ASSERT(valid());
}

void HeaderString::clear() {
Expand Down
Loading