-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: RBE, Docker sandbox and bazel fixes #7657
Conversation
Signed-off-by: Lizan Zhou <[email protected]>
Signed-off-by: Lizan Zhou <[email protected]>
``` | ||
|
||
Change the value of `--remote_cache`, `--remote_executor` and `--remote_instance_name` for your remote build services. Tests can | ||
be run in remote execution too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see what this paragraph adds to the above example. The above example seems complete.
Change the value of `--remote_cache`, `--remote_executor` and `--remote_instance_name` for your remote build services. Tests can | ||
be run in remote execution too. | ||
|
||
Note: Currently the test run configuration in `.bazelrc` doesn't download test binaries and test logs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
downloading failed test logs by default seems really useful, particularly if something flakes. If you can't get the log then you may be out of luck.
However, downloading the test binaries seems less useful and more expensive. Is there a way to tease these options apart?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is what I'm asking in bazelbuild/bazel#8934
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. You might want to reference that bug in a comment here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually that issue is closed now; can you update the default to download test logs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix is not in released bazel yet.
bazel build //source/exe:envoy-static --config=remote-clang \ | ||
--remote_cache=grpcs://remotebuildexecution.googleapis.com \ | ||
--remote_executor=grpcs://remotebuildexecution.googleapis.com \ | ||
--remote_instance_name=projects/envoy-ci/instances/default_instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyone can use these googleapis for free?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's why I the paragraph:
Change the value of
--remote_cache
,--remote_executor
and--remote_instance_name
for your remote build services. Tests can be run in remote execution too.
@jmarantz gently ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay, was traveling and this fell off my radar.
Change the value of `--remote_cache`, `--remote_executor` and `--remote_instance_name` for your remote build services. Tests can | ||
be run in remote execution too. | ||
|
||
Note: Currently the test run configuration in `.bazelrc` doesn't download test binaries and test logs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. You might want to reference that bug in a comment here?
Description:
Added RBE and Docker sandbox how-to.
Make macOS ASAN working again.
Risk Level:
Testing:
Docs Changes: Developer docs
Release Notes: