-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: gdb test wrapper script and docs. #749
Conversation
tools/bazel-test-gdb
Outdated
# | ||
# tools/bazel-test-gdb //test/foo:bar --some_other --bazel_args | ||
|
||
if [[ ! "$1" =~ //.*:.* ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we support a repository prefix here also like @envoy//test/foo:bar ?
tools/bazel-test-gdb
Outdated
trap cleanup EXIT | ||
|
||
bazel test "$@" --strategy=TestRunner=standalone --cache_test_results=no \ | ||
--test_output=summary --run_under="$PWD/tools/gen_gdb_wrapper_script.py ${GDB_RUNNER}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will likely run this from a parent directory (same for istio). Instead of $PWD can we pull out script directory and use that?
tools/gen_gdb_wrapper_script.py
Outdated
os.environ[k] = v | ||
|
||
os.chdir('${working_dir}') | ||
os.system('gdb ${test_path}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is test_path always a script (single arg)? Do we every need gdb --args ?
Fixed the above and verified from envoy-consumer. |
Signed-off-by: Matt Klein <[email protected]>
Signed-off-by: Matt Klein <[email protected]> Signed-off-by: Pradeep Rao <[email protected]>
Signed-off-by: Matt Klein <[email protected]> Signed-off-by: Pradeep Rao <[email protected]>
Signed-off-by: Matt Klein <[email protected]> Signed-off-by: Pradeep Rao <[email protected]>
Signed-off-by: Matt Klein <[email protected]> Signed-off-by: Pradeep Rao <[email protected]>
commit 34f89c5a567694d8dda4d9c7f4ddfa76124932e7 Author: Matt Klein <[email protected]> Date: Thu May 19 16:25:24 2022 +0000 grpc: fix previous patch Once approved this will be squashed into the previous commit. Signed-off-by: Matt Klein <[email protected]> commit 58c8e2eb1bcdfa1e9a4f2829c49cbf98085d48c0 Author: Pradeep Rao <[email protected]> Date: Thu May 12 16:17:55 2022 +0000 healthcheck: fix grpc inline removal crashes (envoyproxy#749) Signed-off-by: Pradeep Rao <[email protected]> Signed-off-by: Pradeep Rao <[email protected]>
commit 8a9cc439ca15c0ca8905bf0c3f7a2ff042da1171 Author: Matt Klein <[email protected]> Date: Thu May 19 16:25:24 2022 +0000 grpc: fix previous patch Once approved this will be squashed into the previous commit. Signed-off-by: Matt Klein <[email protected]> commit 2e911a1d6da10f3d93d6349884cb345955793245 Author: Pradeep Rao <[email protected]> Date: Thu May 12 16:05:33 2022 +0000 healthcheck: fix grpc inline removal crashes (envoyproxy#749) Signed-off-by: Pradeep Rao <[email protected]> Signed-off-by: Pradeep Rao <[email protected]>
commit 0eb6bda4cf0eb338b3144c1df70b39b6a6eaf303 Author: Matt Klein <[email protected]> Date: Thu May 19 16:25:24 2022 +0000 grpc: fix previous patch Once approved this will be squashed into the previous commit. Signed-off-by: Matt Klein <[email protected]> commit 4d30a0ecd5b11c78e7d532ab4f20703b733edf24 Author: Pradeep Rao <[email protected]> Date: Thu May 12 15:41:10 2022 +0000 healthcheck: fix grpc inline removal crashes (envoyproxy#749) Signed-off-by: Pradeep Rao <[email protected]> Signed-off-by: Pradeep Rao <[email protected]>
commit a5872b87cdf9853294ac4d5a9a22a633d812bd80 Author: Matt Klein <[email protected]> Date: Thu May 19 16:25:24 2022 +0000 grpc: fix previous patch Once approved this will be squashed into the previous commit. Signed-off-by: Matt Klein <[email protected]> commit 4b24c6dc5809447fb79cec18ce0235dc9cbdb620 Author: Pradeep Rao <[email protected]> Date: Thu May 12 15:37:46 2022 +0000 healthcheck: fix grpc inline removal crashes (envoyproxy#749) Signed-off-by: Pradeep Rao <[email protected]> Signed-off-by: Pradeep Rao <[email protected]>
Signed-off-by: Matt Klein <[email protected]> Signed-off-by: Pradeep Rao <[email protected]> Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Matt Klein <[email protected]> Signed-off-by: Pradeep Rao <[email protected]> Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Matt Klein <[email protected]> Signed-off-by: Pradeep Rao <[email protected]> Signed-off-by: Ryan Northey <[email protected]>
commit 34f89c5a567694d8dda4d9c7f4ddfa76124932e7 Author: Matt Klein <[email protected]> Date: Thu May 19 16:25:24 2022 +0000 grpc: fix previous patch Once approved this will be squashed into the previous commit. Signed-off-by: Matt Klein <[email protected]> commit 58c8e2eb1bcdfa1e9a4f2829c49cbf98085d48c0 Author: Pradeep Rao <[email protected]> Date: Thu May 12 16:17:55 2022 +0000 healthcheck: fix grpc inline removal crashes (envoyproxy#749) Signed-off-by: Pradeep Rao <[email protected]> Signed-off-by: Pradeep Rao <[email protected]>
Signed-off-by: Matt Klein <[email protected]> Signed-off-by: Tianyu Xia <[email protected]>
Signed-off-by: Matt Klein <[email protected]> Signed-off-by: Pradeep Rao <[email protected]> Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Matt Klein <[email protected]> Signed-off-by: Pradeep Rao <[email protected]> Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Matt Klein <[email protected]> Signed-off-by: Pradeep Rao <[email protected]> Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Matt Klein <[email protected]> Signed-off-by: Amila Senadheera <[email protected]>
Description: disable until #748 is fixed. Risk Level: low given stats are being flushed every 5 secs. Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
Description: tag with two updates: - #749. Disable lifecycle event-base stat flushing until #748 is resolved. - #751 to get additional data of the number of retries attempted by envoy mobile Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
Description: disable until #748 is fixed. Risk Level: low given stats are being flushed every 5 secs. Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
Description: tag with two updates: - #749. Disable lifecycle event-base stat flushing until #748 is resolved. - #751 to get additional data of the number of retries attempted by envoy mobile Signed-off-by: Jose Nino <[email protected]> Signed-off-by: JP Simard <[email protected]>
No description provided.