cm: fix secondary init bug #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we get additional CDS updates while we are still initializing, we would not previously initialize new secondary clusters. This would cause init to never complete in certain cases. This commit also adds more init logging to help with debugging similar issues.
|
@lyft/network-team @kyessenov this is probably the other hang you saw. I added more logging also so that we can more easily debug other issues like this. |
ccaraman
approved these changes
Mar 13, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Removes some build configurations that we don't explicitly use anywhere. Documentation suggests explicitly using `--ios_multi_cpus` or `--fat_apk_cpu`. Follow up to envoyproxy/envoy-mobile#563 (comment) Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Removes some build configurations that we don't explicitly use anywhere. Documentation suggests explicitly using `--ios_multi_cpus` or `--fat_apk_cpu`. Follow up to envoyproxy/envoy-mobile#563 (comment) Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we get additional CDS updates while we are still initializing, we would
not previously initialize new secondary clusters. This would cause init to
never complete in certain cases.
This commit also adds more init logging to help with debugging similar issues.