hot restart: fix race condition when fetching parent stats #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See code comments for more info.
|
@lyft/network-team @kyessenov I was able to repro your issue locally by setting the stat flush interval to 5ms. With this fix I'm able to do 1000 restarts at 100ms intervals. Appreciate it if you could give this a shot. This is probably not going to fix the other startup issue we saw. We will need to add more logging to get to the bottom of that. I will do that in a separate change. |
ccaraman
approved these changes
Mar 13, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
lambdai
pushed a commit
to lambdai/envoy-dai
that referenced
this pull request
Jul 21, 2020
Signed-off-by: Taegyun Kim <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Include the `ios` config by default when using `release-ios`. Also updates the docs for clarity on usage. Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Include the `ios` config by default when using `release-ios`. Also updates the docs for clarity on usage. Signed-off-by: Michael Rebello <[email protected]> Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See code comments for more info.