Fix the BoringSSL link in the requirements section of the docs. #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattklein123
approved these changes
Feb 12, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Shrink and better document the debug image before: 722MB after: 236MB (Not counting envoy itself) Fixes envoyproxy#423 Needs istio/old_pilot_repo#1202 to fully work ```release-note Reduce proxy debug image by 2/3rd (486Mb) yet as functional ``` * Alignement fix
lizan
pushed a commit
to lizan/envoy
that referenced
this pull request
Apr 24, 2020
Use the proxy-wasm-cpp-sdk and basel to build test_cpp.wasm.
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
* Work around BoringSSL bitcode linker warning When linking envoy-mobile to an iOS app that ships with bitcode, you get these warnings from the linker: ``` ld: warning: Linker asked to preserve internal global: 'sk_CRYPTO_BUFFER_call_free_func' ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func' ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func' ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func' ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func' ``` I have submitted an upstream patch to fix this https://boringssl-review.googlesource.com/c/boringssl/+/37804 in the meantime I've applied that patch here. Signed-off-by: Keith Smiley <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Reverting #470 which is a patch to boringssl https://boringssl-review.googlesource.com/c/boringssl/+/37804 indicates that this patch was added to avoid a linker error, so given CI passes I assume it can be reverted. Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a Part of #23758 Fixes #471 Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
* Work around BoringSSL bitcode linker warning When linking envoy-mobile to an iOS app that ships with bitcode, you get these warnings from the linker: ``` ld: warning: Linker asked to preserve internal global: 'sk_CRYPTO_BUFFER_call_free_func' ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func' ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func' ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func' ld: warning: Linker asked to preserve internal global: 'sk_X509_call_free_func' ``` I have submitted an upstream patch to fix this https://boringssl-review.googlesource.com/c/boringssl/+/37804 in the meantime I've applied that patch here. Signed-off-by: Keith Smiley <[email protected]> Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Reverting #470 which is a patch to boringssl https://boringssl-review.googlesource.com/c/boringssl/+/37804 indicates that this patch was added to avoid a linker error, so given CI passes I assume it can be reverted. Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a Part of #23758 Fixes #471 Signed-off-by: Alyssa Wilk <[email protected]> Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.