test: add explicit ctor/dtor to more mocks #4423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Snow Pettersen <[email protected]>
Signed-off-by: Snow Pettersen <[email protected]>
zuercher
previously approved these changes
Sep 14, 2018
|
Looks like CircleCI is having trouble again. |
|
Yeah, I'll keep an eye on their status update and rerun CI once they recover |
Signed-off-by: Snow Pettersen <[email protected]>
|
@zuercher Reran the tests, we're green now! |
htuch
previously approved these changes
Sep 14, 2018
dio
reviewed
Sep 16, 2018
test/mocks/upstream/mocks.cc
Outdated
| @@ -122,7 +130,13 @@ MockClusterUpdateCallbacks::MockClusterUpdateCallbacks() {} | |||
|
|
|||
| MockClusterUpdateCallbacks::~MockClusterUpdateCallbacks() {} | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Seems like removing line 133 makes the formatter happy.
Signed-off-by: Snow Pettersen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: As per https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#making-the-compilation-faster, moving ctor/dtor definition out of the header files can lead to faster builds.
Risk Level: Low, minor refactor
Testing: Run CI
Docs Changes: n/a
Release Notes: n/a