thrift_proxy: fix another variant of the early close bug #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case, the early close fix only worked if the upstream connection hadn't yet been formed. Instead, handle early close as long as there isn't a pending oneway request. Risk Level: low Testing: added tests, ran 2000x each Doc Changes: n/a Release Notes: n/a Fixes: envoyproxy#4416 Signed-off-by: Stephan Zuercher <[email protected]>
|
@brirams @rgs1 @fishcakez PTAL |
Signed-off-by: Stephan Zuercher <[email protected]>
|
Build failures are circleci-related. Will kick CI once they've recovered. |
Signed-off-by: Stephan Zuercher <[email protected]>
|
@junr03 can take a look? I'd like to get this merged since it fixes a test that's been failing regularly the last couple of days? |
rgs1
reviewed
Sep 14, 2018
| TEST_P(ThriftConnManagerIntegrationTest, EarlyCloseWithUpstream) { | ||
| initializeCall(DriverMode::Success); | ||
|
|
||
| std::string partial_request = request_bytes_.toString().substr(0, request_bytes_.length() - 5); |
| TEST_P(ThriftConnManagerIntegrationTest, OnewayEarlyClosePartialRequest) { | ||
| initializeOneway(); | ||
|
|
||
| std::string partial_request = request_bytes_.toString().substr(0, request_bytes_.length() - 1); |
Signed-off-by: Stephan Zuercher <[email protected]>
brian-pane
approved these changes
Sep 14, 2018
junr03
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case, the early close fix only worked if the upstream connection
hadn't yet been formed. Instead, handle early close as long as there
isn't a pending oneway request. Also discovered a case where the
Unframed transport causes an RPC to start on a zero-length buffer with
end_stream set.
Risk Level: low
Testing: added tests, ran 2000x each
Doc Changes: n/a
Release Notes: n/a
Fixes: #4416
Signed-off-by: Stephan Zuercher [email protected]