test: improve error output of router_check #4392
Conversation
Explains what the different values output means and writes to stderr instead of stdout. This should make the error output appear in the testlogs. Signed-off-by: Snow Pettersen <[email protected]>
Signed-off-by: Snow Pettersen <[email protected]>
Signed-off-by: Snow Pettersen <[email protected]>
There was a problem hiding this comment.
Would you mind fixing a bug with the bad config file section?
I think that if the subshell that runs $PATH_BIN for the bad config file doesn't error out (e.g. the bad config is successfully parsed) then the if statement won't get run because the subshell succeeded. This means the output doesn't get checked.
I think it should use the same pattern as the failure test case, with || echo "${BAD_CONFIG_OUTPUT:-no output}" and the if statement as a separate command.
| @@ -26,8 +26,8 @@ BAD_CONFIG_OUTPUT=$(("${PATH_BIN}" "${PATH_CONFIG}/Redirect.golden.json" "${PATH | |||
|
|
|||
| # Failure test case | |||
| echo testing failure test case | |||
| FAILURE_OUTPUT=$("${PATH_BIN}" "${PATH_CONFIG}/TestRoutes.yaml" "${PATH_CONFIG}/Weighted.golden.json" "--details") || | |||
| FAILURE_OUTPUT=$("${PATH_BIN}" "${PATH_CONFIG}/TestRoutes.yaml" "${PATH_CONFIG}/Weighted.golden.json" "--details" 2>&1) || | |||
| echo ${FAILURE_OUTPUT} | |||
There was a problem hiding this comment.
What do you think of making this echo "${FAILURE_OUTPUT:-no output}"? That will produce a line that says "no output" should that happen.
This line should also be indented two, since it's a continuation of the previous line.
There was a problem hiding this comment.
Sounds reasonable to me
Signed-off-by: Snow Pettersen <[email protected]>
|
Updated this PR with your suggested fix, ptal. |
Description: Explains what the different values output means and writes to stderr
instead of stdout. This should make the error output appear in the
testlogs.
Risk Level: Low, change to test error reporting
Testing: bazel test //test/...
Docs Changes: n/a
Release Notes: n/a