Allow copy elision on temporary args #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows copy elision on unreferenced temporary objects
Reflejo
changed the title
mattklein123
approved these changes
Feb 4, 2017
|
@Reflejo please fix format and merge master |
|
@mattklein123 The format problem is nothing I changed, do you want me to fix with |
|
See the CI errors. You need run 'make fix_format' target which will run clang-format for you. |
|
@mattklein123 yea I saw it and that's what I meant, the fix_format changes are unrelated to the PR: f018ad9 Pushed it regardless EDIT: nvm they were related 🦆 |
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of mixerclient This PR will be merged automatically once checks are successful. ```release-note none ```
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
envoyproxy#424) * zh-translation:docs/root/configuration/upstream/cluster_manager/cluster_runtime.rst * zh-translation:docs/root/configuration/upstream/cluster_manager/cluster_runtime.rst * fix translation issue * fix translation issue
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Alan Chiu <[email protected]> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: Rename Envoy to EnvoyClient Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Alan Chiu <[email protected]> For an explanation of how to fill out the fields, please see the relevant section in [PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/master/PULL_REQUESTS.md) Description: Rename Envoy to EnvoyClient Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows copy elision on these 2 unreferenced temporary objects