Verify that service cluster is set in case LS tracing is enabled #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test please. you might move the tracing configuration load to a static utility function that is easier to test. |
|
@RomanDzhabarov thanks for following up on my testing issue with this PR. |
|
Sounds good, will add tests in a bit today. |
mattklein123
reviewed
Feb 5, 2017
|
|
||
| NiceMock<Server::MockInstance> server; | ||
| std::string cluster_not_set = ""; | ||
| EXPECT_CALL(server.local_info_, clusterName()).WillOnce(ReturnRef(cluster_not_set)); |
There was a problem hiding this comment.
Just modify server.local_info_.cluster_name_ directly. You don't need a new variable or the EXPECT_CALL.
| @@ -119,5 +120,38 @@ TEST(ConfigurationImplTest, BadListenerConfig) { | |||
| EXPECT_THROW(config.initialize(*loader), Json::Exception); | |||
| } | |||
|
|
|||
| TEST(ConfigurationImplTest, NotSetServiceClusterWhenLSTracing) { | |||
There was a problem hiding this comment.
ServiceClusterNotSetWhenLSTracing
mattklein123
approved these changes
Feb 6, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Add tcp filter * collect some data. * Add WriteFilter. * integrate with mixer_control. * Add integration test. * use NamedNetworkFilerConfigFactory
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.