Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "jwt_authn: Add logic to refetch JWT on KID mismatch (#36458)" #37763

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

wbpcode
Copy link
Member

@wbpcode wbpcode commented Dec 19, 2024

Commit Message: Revert "jwt_authn: Add logic to refetch JWT on KID mismatch (#36458)"
Additional Description:

To resolve the frequent jwt test failures. See #37720.

It's merged recently and the implementation of that feature has obvious thread-safty problem and lifetime problem. We can never use TLS as a way to prevent concurrent async fetching and cannot post a task to another thread without any lifetime insurance.

So, reverted it.

Risk Level: low.
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @abeyad
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #37763 was opened by wbpcode.

see: more, trace.

@wbpcode
Copy link
Member Author

wbpcode commented Dec 19, 2024

cc @adisuissa @tyxia

@wbpcode
Copy link
Member Author

wbpcode commented Dec 19, 2024

cc @arulthileeban

Copy link
Member

@tyxia tyxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@tyxia tyxia merged commit b9c4ff2 into envoyproxy:main Dec 19, 2024
24 of 25 checks passed
@wbpcode wbpcode deleted the dev-revert-jwt branch December 19, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants