Hoist java_rules into envoy
#37590
Merged
Hoist java_rules into envoy
#37590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- switch to release download url - drop strip_prefix since it's missing at the new url - add rules_java to bazel/repository_locations.bzl - add rules_java to _com_google_protobuf() in bazel/repositories.bzl Signed-off-by: Alejandro R. Sedeño <[email protected]>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: Alejandro R. Sedeño <[email protected]>
asedeno
requested review from
RyanTheOptimist,
alyssawilk,
abeyad and
fredyw
as code owners
phlax
approved these changes
Dec 9, 2024
repokitteh-read-only
bot
removed
the
deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf 29.0+ depends on
rules_java, so let's bring it into Envoy core, syncing what we import in core and mobile.strip_prefixsince the new url doesn't have a prefix to strip.rules_javatobazel/repository_locations.bzlrules_javato_com_google_protobuf()inbazel/repositories.bzlRisk Level: low
Testing: CI