Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contrib] Stop building ICU tools to fix gcc Envoy build #37039

Closed
wants to merge 1 commit into from

[contrib] Stop building ICU tools to fix gcc Envoy build

01a4bcc
Select commit
Loading
Failed to load commit list.
Closed

[contrib] Stop building ICU tools to fix gcc Envoy build #37039

[contrib] Stop building ICU tools to fix gcc Envoy build
01a4bcc
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Android tests skipped Nov 7, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/37039/main@01a4bcc)

krinkinmu @krinkinmu 01a4bcc #37039 merge main@01d94d2

[contrib] Stop building ICU tools to fix gcc Envoy build

Commit Message:

Clang and gcc are subtly different and it seems to be the cause of contrib build failures reported in
#31807 (e.g., when using gcc to link the final binary it results in a bunch of essential for gcc C++ symbols like __gxx_personality_v0).

This issue could be addressed (i.e., Envoy can be built using gcc). However, given that it only happens when we build ICU binary tools and those tools aren't used by Envoy directly or the build system, we can just not build them and address the issue this way.

Additional Description:

It addresses the immediate problem reported in #31807, but by itself it's not enough to fix gcc builds, so I'm not marking this PR as fixing that issue because of that, since ultimately we want to achieve successful gcc builds.

Risk Level: Low
Testing: building contrib and non-contrib Envoy using --config=gcc and --config=docker-gcc
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Environment

Request variables

Key Value
ref eda7d87
sha 01a4bcc
pr 37039
base-sha 01d94d2
actor krinkinmu @krinkinmu
message [contrib] Stop building ICU tools to fix gcc Envoy build...
started 1731004750.830565
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 33
patch 0
dev true