Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contrib][postgres] Remove <> after constructor in the PG proxy code #37038

Merged
merged 1 commit into from
Nov 8, 2024

[postgres] Remove <> after constructor in the PG proxy

0e250f8
Select commit
Loading
Failed to load commit list.
Merged

[contrib][postgres] Remove <> after constructor in the PG proxy code #37038

[postgres] Remove <> after constructor in the PG proxy
0e250f8
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Perf skipped Nov 7, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/37038/main@0e250f8)

krinkinmu @krinkinmu 0e250f8 #37038 merge main@01d94d2

[contrib][postgres] Remove <> after constructor in the PG proxy code

Commit Message:

Angle brackets are not required after constructor and, maybe, aren't even correct, though I'm not 100% sure on what the standard says on the matter.

It seems like clang is fine with this syntax, but when you try to build Envoy with gcc it complains:

./contrib/postgres_proxy/filters/network/source/postgres_message.h: At global scope:
./contrib/postgres_proxy/filters/network/source/postgres_message.h:397:14: error: expected unqualified-id before ')' token
  397 |   Sequence<>() = default;
      |              ^
Target //contrib/exe:envoy-static failed to build

Given that it's at least unusual to have angle brackets after constructor in a class template specialization let's remove them and satisfy both gcc and clang.

Additional Description:

It's one of the issue that prevent contrib build with gcc. It's not the original issue reported in #31807, but that issue is what started the investigation.

Risk Level: Low
Testing: bazel build with --config=gcc and --config=docker-gcc options and in various compliation modes.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Environment

Request variables

Key Value
ref daaf756
sha 0e250f8
pr 37038
base-sha 01d94d2
actor krinkinmu @krinkinmu
message [contrib][postgres] Remove <> after constructor in the PG proxy code...
started 1730999238.843967
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 33
patch 0
dev true