socket: removing some exceptions #36991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
Signed-off-by: Alyssa Wilk <[email protected]>
yanavlasov
approved these changes
Nov 8, 2024
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Feb 19, 2025
Relates: envoyproxy/envoy#36991 Relates: envoyproxy/envoy#36773
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Feb 19, 2025
Relates: envoyproxy/envoy#36991 Relates: envoyproxy/envoy#36773
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Feb 19, 2025
Relates: envoyproxy/envoy#36991 Relates: envoyproxy/envoy#36773
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Feb 20, 2025
Relates: envoyproxy/envoy#36991 Relates: envoyproxy/envoy#36773 Relates: envoyproxy/envoy#36821
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Feb 20, 2025
Relates: envoyproxy/envoy#36991 Relates: envoyproxy/envoy#36773 Relates: envoyproxy/envoy#36821
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Feb 20, 2025
Relates: envoyproxy/envoy#36991 Relates: envoyproxy/envoy#36773 Relates: envoyproxy/envoy#36821
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Feb 20, 2025
Relates: envoyproxy/envoy#36991 Relates: envoyproxy/envoy#36773 Relates: envoyproxy/envoy#36821
sayboras
added a commit
to cilium/proxy
that referenced
this pull request
Feb 22, 2025
Relates: envoyproxy/envoy#36991 Relates: envoyproxy/envoy#36773 Relates: envoyproxy/envoy#36821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unlike most exception PRs this includes a functional change to how Envoy handles completely invalid sockets or failed system calls. Errors should be connection-local rather than throwing to whatever might catch, so it should be a whole sale improvement and is unlikely to affect anyone whose syscalls work.
Risk Level: medium
Testing: updated tests
Docs Changes: n/a
Release Notes: n/a
envoyproxy/envoy-mobile#176