Take absolute values when doing DNS jitter. #36953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @keithmattix |
|
/assign @Stevenjin8 |
|
/wait |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Steven Jin Xuan <[email protected]>
Signed-off-by: Steven Jin Xuan <[email protected]>
Signed-off-by: Steven Jin Xuan <[email protected]>
Signed-off-by: Steven Jin Xuan <[email protected]>
Signed-off-by: Steven Jin Xuan <[email protected]>
Stevenjin8
force-pushed
the
bug/dns-jitter
branch
from
7f05fe3 to
7ccd6d5
Compare
|
/retest |
Signed-off-by: Steven Jin Xuan <[email protected]>
Stevenjin8
force-pushed
the
bug/dns-jitter
branch
from
6e8e501 to
73b2825
Compare
|
/retest |
|
/lgtm api |
|
@KBaichoo Bump |
KBaichoo
previously approved these changes
Nov 12, 2024
Signed-off-by: Steven Jin Xuan <[email protected]>
|
/retest |
KBaichoo
approved these changes
Nov 13, 2024
This was referenced Nov 15, 2024
Stevenjin8
added a commit
to Stevenjin8/envoy
that referenced
this pull request
Dec 4, 2024
Signed-off-by: Steven Jin Xuan <[email protected]>
Stevenjin8
added a commit
to Stevenjin8/envoy
that referenced
this pull request
Dec 4, 2024
Signed-off-by: Steven Jin Xuan <[email protected]>
Merged
phlax
pushed a commit
that referenced
this pull request
Dec 5, 2024
Signed-off-by: Steven Jin Xuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Take absolute values when doing DNS jitter.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] #36943
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]
In response to #36943. Jitter is generated by taking a random value from the random generator and creating a std::chrono::millisecond.
Since the random value is a uint64, I figured that the resulting std::chrono::millisecond would have to be positive.
However, std::chrono::millisecond uses a int64 under the hood, so large random values were being converted to negative numbers.
For example, if the random generator returned 0x8000000000000000, there would be a jitter of -9223372036854775808ms.
This jitter would in turn case the refresh timer to be negative.