Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel/repo: Fix version export (for apt archive) #36644

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

phlax
Copy link
Member

@phlax phlax commented Oct 16, 2024

No description provided.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 16, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @moderation

🐱

Caused by: #36644 was opened by phlax.

see: more, trace.

@phlax phlax force-pushed the repo-versions branch 2 times, most recently from a74a836 to 9b500af Compare October 16, 2024 15:12
jmarantz
jmarantz previously approved these changes Oct 16, 2024
@phlax phlax enabled auto-merge (squash) October 16, 2024 15:42
Signed-off-by: Ryan Northey <[email protected]>
@phlax
Copy link
Member Author

phlax commented Oct 16, 2024

apologies @jmarantz my initial attempt at a format fix didnt work - should work now

Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phlax phlax merged commit ca6f4d6 into envoyproxy:main Oct 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants