ext_proc: skip timeout timer on trailer in async mode. #36524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tyxia <[email protected]>
Signed-off-by: tyxia <[email protected]>
Signed-off-by: tyxia <[email protected]>
yanavlasov
approved these changes
Oct 10, 2024
Stevenjin8
pushed a commit
to Stevenjin8/envoy
that referenced
this pull request
Oct 10, 2024
) Commit Message: Like header and body, timer/timeout should be skipped on trailer as well in async. It is because there is no response/ or response is ignored. Risk Level: Low Testing: Integration test Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: tyxia <[email protected]> Signed-off-by: Steven Jin Xuan <[email protected]>
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Oct 17, 2024
) Commit Message: Like header and body, timer/timeout should be skipped on trailer as well in async. It is because there is no response/ or response is ignored. Risk Level: Low Testing: Integration test Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A --------- Signed-off-by: tyxia <[email protected]> Signed-off-by: Gustavo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Like header and body, timer/timeout should be skipped on trailer as well in async. It is because there is no response/ or response is ignored.
Risk Level: Low
Testing: Integration test (test the timeout on header, body and trailer)
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A