xds: make certificate provider instance name required #36441
Merged
CI (Envoy) / Mobile/Perf
skipped
Oct 3, 2024 in 0s
Check was skipped
This check was not triggered in this CI run
Details
Request (pr/36441/main@5629160)
5629160 
#36441 merge main@505f125
xds: make certificate provider instance name required
Commit Message: xds: make certificate provider instance name required
Additional Description: The comment saying that there is a default value for this field is misleading. All existing gRPC implementations have this as a required field. Note that this change does not affect Envoy, since Envoy does not yet support this field. However, I've added a PGV annotation (used by Envoy but not by gRPC) to avoid confusion when Envoy eventually adds support for this field.
Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A
Environment
Request variables
| Key | Value |
|---|---|
| ref | 0705390 |
| sha | 5629160 |
| pr | 36441 |
| base-sha | 505f125 |
| actor | @markdroth |
| message | xds: make certificate provider instance name required... |
| started | 1727998421.503923 |
| target-branch | main |
| trusted | false |
Build image
Container image/s (as used in this CI run)
| Key | Value |
|---|---|
| default | envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
| mobile | envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c |
Version
Envoy version (as used in this CI run)
| Key | Value |
|---|---|
| major | 1 |
| minor | 32 |
| patch | 0 |
| dev | true |
Loading