Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix install commands for linux distribution #36226

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

akshaysngupta
Copy link
Contributor

@akshaysngupta akshaysngupta commented Sep 19, 2024

Commit Message: Fix install commands for linux distribution
Additional Description:
Risk Level: Low
Testing: manual testing
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@akshaysngupta akshaysngupta changed the title Fix install commands for linux distribution docs: fix install commands for linux distribution Sep 19, 2024
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure this fixes anything - wget is more common to a base system - altho tbf can be absent from a totally barebones system

curl pretty much always must be installed

how about instead adding install lines for

  • wget
  • sudo
  • gpg

as these are the requirements

docs/root/start/install.rst Show resolved Hide resolved
docs/root/start/install.rst Show resolved Hide resolved
@phlax phlax self-assigned this Sep 19, 2024
Signed-off-by: Akshay Gupta <[email protected]>
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @akshaysngupta - appreciated

@phlax phlax enabled auto-merge (squash) September 19, 2024 18:57
@phlax phlax merged commit d6120f3 into envoyproxy:main Sep 19, 2024
30 of 31 checks passed
@akshaysngupta akshaysngupta deleted the patch-1 branch September 19, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants