Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/example: Dont build/test the filter example in Envoy CI #36038

Merged
merged 1 commit into from
Sep 9, 2024

ci/example: Dont build/test the filter example in Envoy CI

e744b3c
Select commit
Loading
Failed to load commit list.
Merged

ci/example: Dont build/test the filter example in Envoy CI #36038

ci/example: Dont build/test the filter example in Envoy CI
e744b3c
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Release validation skipped Sep 9, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/36038/main@e744b3c)

phlax @phlax e744b3c #36038 merge main@a01c046

ci/example: Dont build/test the filter example in Envoy CI

Currently the compile-time-options/msan/asan tests are run in the context of the filter-example

This adds a lot of complexity to the build and messes up our test artefacts.

The example is not well maintained - it has circle CI configured which hasnt passed in years. Ideally we close that repo and add it instead to the examples repo

Environment

Request variables

Key Value
ref 1d2574c
sha e744b3c
pr 36038
base-sha a01c046
actor phlax @phlax
message ci/example: Dont build/test the filter example in Envoy CI...
started 1725885737.43811
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 32
patch 0
dev true