-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/format: Remove ~unused CI format test #35986
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <[email protected]>
096af3e
to
d15a947
Compare
wbpcode
approved these changes
Sep 5, 2024
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Sep 30, 2024
this test was never really run as `CI_BRANCH` is not automatically set in azp now the thing its testing has moved to bazel so the test is not really correct also im in the process of moving the thing being tested to toolshed (where it will be testsed more comprehensively) Signed-off-by: Ryan Northey <[email protected]>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Sep 30, 2024
this test was never really run as `CI_BRANCH` is not automatically set in azp now the thing its testing has moved to bazel so the test is not really correct also im in the process of moving the thing being tested to toolshed (where it will be testsed more comprehensively) Signed-off-by: Ryan Northey <[email protected]>
phlax
added a commit
that referenced
this pull request
Sep 30, 2024
this test was never really run as `CI_BRANCH` is not automatically set in azp now the thing its testing has moved to bazel so the test is not really correct also im in the process of moving the thing being tested to toolshed (where it will be testsed more comprehensively) Signed-off-by: Ryan Northey <[email protected]>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Sep 30, 2024
this test was never really run as `CI_BRANCH` is not automatically set in azp now the thing its testing has moved to bazel so the test is not really correct also im in the process of moving the thing being tested to toolshed (where it will be testsed more comprehensively) Signed-off-by: Ryan Northey <[email protected]>
asedeno
pushed a commit
to asedeno/envoy
that referenced
this pull request
Oct 1, 2024
this test was never really run as `CI_BRANCH` is not automatically set in azp now the thing its testing has moved to bazel so the test is not really correct also im in the process of moving the thing being tested to toolshed (where it will be testsed more comprehensively) Signed-off-by: Ryan Northey <[email protected]>
phlax
added a commit
that referenced
this pull request
Oct 1, 2024
this test was never really run as `CI_BRANCH` is not automatically set in azp now the thing its testing has moved to bazel so the test is not really correct also im in the process of moving the thing being tested to toolshed (where it will be testsed more comprehensively) Signed-off-by: Ryan Northey <[email protected]>
asedeno
pushed a commit
to asedeno/envoy
that referenced
this pull request
Oct 1, 2024
this test was never really run as `CI_BRANCH` is not automatically set in azp now the thing its testing has moved to bazel so the test is not really correct also im in the process of moving the thing being tested to toolshed (where it will be testsed more comprehensively) Signed-off-by: Ryan Northey <[email protected]> Signed-off-by: Alejandro R. Sedeño <[email protected]>
phlax
added a commit
that referenced
this pull request
Oct 1, 2024
this test was never really run as `CI_BRANCH` is not automatically set in azp now the thing its testing has moved to bazel so the test is not really correct also im in the process of moving the thing being tested to toolshed (where it will be testsed more comprehensively) Signed-off-by: Ryan Northey <[email protected]> Signed-off-by: Alejandro R. Sedeño <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this test was never really run as
CI_BRANCH
is not automatically set in azpnow the thing its testing has moved to bazel so the test is not really correct
also im in the process of moving the thing being tested to toolshed (where it will be testsed more comprehensively)