Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/format: Remove ~unused CI format test #35986

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

phlax
Copy link
Member

@phlax phlax commented Sep 5, 2024

this test was never really run as CI_BRANCH is not automatically set in azp

now the thing its testing has moved to bazel so the test is not really correct

also im in the process of moving the thing being tested to toolshed (where it will be testsed more comprehensively)

@phlax phlax force-pushed the ci-format-test-no branch from 096af3e to d15a947 Compare September 5, 2024 08:45
@phlax phlax merged commit 5c70114 into envoyproxy:main Sep 5, 2024
39 checks passed
phlax added a commit to phlax/envoy that referenced this pull request Sep 30, 2024
this test was never really run as `CI_BRANCH` is not automatically set
in azp

now the thing its testing has moved to bazel so the test is not really
correct

also im in the process of moving the thing being tested to toolshed
(where it will be testsed more comprehensively)

Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit to phlax/envoy that referenced this pull request Sep 30, 2024
this test was never really run as `CI_BRANCH` is not automatically set
in azp

now the thing its testing has moved to bazel so the test is not really
correct

also im in the process of moving the thing being tested to toolshed
(where it will be testsed more comprehensively)

Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit that referenced this pull request Sep 30, 2024
this test was never really run as `CI_BRANCH` is not automatically set
in azp

now the thing its testing has moved to bazel so the test is not really
correct

also im in the process of moving the thing being tested to toolshed
(where it will be testsed more comprehensively)

Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit to phlax/envoy that referenced this pull request Sep 30, 2024
this test was never really run as `CI_BRANCH` is not automatically set
in azp

now the thing its testing has moved to bazel so the test is not really
correct

also im in the process of moving the thing being tested to toolshed
(where it will be testsed more comprehensively)

Signed-off-by: Ryan Northey <[email protected]>
asedeno pushed a commit to asedeno/envoy that referenced this pull request Oct 1, 2024
this test was never really run as `CI_BRANCH` is not automatically set
in azp

now the thing its testing has moved to bazel so the test is not really
correct

also im in the process of moving the thing being tested to toolshed
(where it will be testsed more comprehensively)

Signed-off-by: Ryan Northey <[email protected]>
phlax added a commit that referenced this pull request Oct 1, 2024
this test was never really run as `CI_BRANCH` is not automatically set
in azp

now the thing its testing has moved to bazel so the test is not really
correct

also im in the process of moving the thing being tested to toolshed
(where it will be testsed more comprehensively)

Signed-off-by: Ryan Northey <[email protected]>
asedeno pushed a commit to asedeno/envoy that referenced this pull request Oct 1, 2024
this test was never really run as `CI_BRANCH` is not automatically set
in azp

now the thing its testing has moved to bazel so the test is not really
correct

also im in the process of moving the thing being tested to toolshed
(where it will be testsed more comprehensively)

Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Alejandro R. Sedeño <[email protected]>
phlax added a commit that referenced this pull request Oct 1, 2024
this test was never really run as `CI_BRANCH` is not automatically set
in azp

now the thing its testing has moved to bazel so the test is not really
correct

also im in the process of moving the thing being tested to toolshed
(where it will be testsed more comprehensively)

Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Alejandro R. Sedeño <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants