remove useless import #35934
Merged
remove useless import #35934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zirain <[email protected]>
dbarbosapn
approved these changes
Sep 1, 2024
There was a problem hiding this comment.
Oops, my bad 😄
Would be nice to know why this breaks macos build though.
Also, @mattklein123 could the formatting CI check (and tool) check (and remove) unused imports?
Error: ./source/extensions/filters/network/redis_proxy/proxy_filter.h:3:10: fatal error: 'bits/types/time_t.h' file not found
Error: ERROR: /Users/runner/work/envoy/envoy/source/extensions/filters/network/redis_proxy/BUILD:120:17: Compiling source/extensions/filters/network/redis_proxy/proxy_filter.cc failed: (Exit 1): wrapped_clang_pp failed: error executing command (from target //source/extensions/filters/network/redis_proxy:proxy_filter_lib)not sure why passed on linux but failed on mac m1. |
phlax
approved these changes
Sep 2, 2024
|
@dbarbosapn if you can suggest some tooling and we can make it work with bazel then i think that would be a great idea this conversation has come up previously - but not sure how best to resolve - there is "include what you use" but that does something slightly different (if related) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: remove unseless import, which broken macos build, see #35933
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]