Make http3 codec not encode empty trailers block #35907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raven Black <[email protected]>
Signed-off-by: Raven Black <[email protected]>
Signed-off-by: Raven Black <[email protected]>
|
/retest |
|
(Failure appears to be a flake added in #34461) |
|
/retest |
Signed-off-by: Raven Black <[email protected]>
RyanTheOptimist
previously approved these changes
Sep 3, 2024
phlax
reviewed
Sep 3, 2024
changelogs/current.yaml
Outdated
| @@ -107,7 +107,9 @@ bug_fixes: | |||
| - area: http3 | |||
| change: | | |||
| Fixed a bug where an empty trailers block could be sent. This would occur if a filter removed | |||
| the last trailer - a likely occurrence with the ``grpc_web_filter``. | |||
| the last trailer - a likely occurrence with the ``grpc_web_filter``. This change makes http3 codec | |||
| behave the same way http2 codec does, converting an empty trailers block to no trailers. | |||
There was a problem hiding this comment.
Suggested change
| behave the same way http2 codec does, converting an empty trailers block to no trailers. | |
| behave the same way HTTP/2 codec does, converting an empty trailers block to no trailers. |
changelogs/current.yaml
Outdated
| @@ -107,7 +107,9 @@ bug_fixes: | |||
| - area: http3 | |||
| change: | | |||
| Fixed a bug where an empty trailers block could be sent. This would occur if a filter removed | |||
| the last trailer - a likely occurrence with the ``grpc_web_filter``. | |||
| the last trailer - a likely occurrence with the ``grpc_web_filter``. This change makes http3 codec | |||
There was a problem hiding this comment.
Suggested change
| the last trailer - a likely occurrence with the ``grpc_web_filter``. This change makes http3 codec | |
| the last trailer - a likely occurrence with the ``grpc_web_filter``. This change makes HTTP/3 codec |
changelogs/current.yaml
Outdated
| the last trailer - a likely occurrence with the ``grpc_web_filter``. | ||
| the last trailer - a likely occurrence with the ``grpc_web_filter``. This change makes http3 codec | ||
| behave the same way http2 codec does, converting an empty trailers block to no trailers. | ||
| This behavior can be reverted by setting the runtime guard ``envoy.reloadable_features.http3_remove_empty_trailers`` to false. |
There was a problem hiding this comment.
Suggested change
| This behavior can be reverted by setting the runtime guard ``envoy.reloadable_features.http3_remove_empty_trailers`` to false. | |
| This behavior can be reverted by setting the runtime guard ``envoy.reloadable_features.http3_remove_empty_trailers`` to ``false``. |
Signed-off-by: Raven Black <[email protected]>
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Make http3 codec not encode empty trailers block
Additional Description: http3 and
grpc_web_filtercombined resulted in an incompatibility with Chrome - a grpc web request received a response with an empty trailers block, which Chrome treats as a network error. The http2 codec had a special case in it for empty trailers, which was not mimicked in the http3 codec. This PR makes the http3 codec similar to the http2 codec in this respect, and adds an integration test ensuring that this behavior is in all downstream codecs.Risk Level: Small. It is a behavior change, but from an already malfunctioning state in a rare edge case.
Testing: Added integration test which fails before the change and passes after.
Docs Changes: n/a
Release Notes: Yes
Platform Specific Features: n/a