Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhide http3_protocol_options in HttpConnectionManager #35763

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Unhide http3_protocol_options in HttpConnectionManager #35763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
788c8cf
Unhide http3_protocol_options in HttpConnectionManager
ravenblackx Aug 20, 2024
28e9746
Add relnote
ravenblackx Aug 20, 2024
4e10338
Also reveal the HTTP enum
ravenblackx Aug 20, 2024
6e1e9d3
Merge branch 'main' into reveal_http3
ravenblackx Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,8 @@ message HttpConnectionManager {
// Prior knowledge is allowed).
HTTP2 = 2;

// [#not-implemented-hide:] QUIC implementation is not production ready yet. Use this enum with
// caution to prevent accidental execution of QUIC code. I.e. `!= HTTP2` is no longer sufficient
// to distinguish HTTP1 and HTTP2 traffic.
// The connection manager will assume that the client is speaking HTTP/3.
// This needs to be consistent with listener and transport socket config.
HTTP3 = 3;
}

Expand Down Expand Up @@ -474,7 +473,6 @@ message HttpConnectionManager {
[(udpa.annotations.security).configure_for_untrusted_downstream = true];

// Additional HTTP/3 settings that are passed directly to the HTTP/3 codec.
// [#not-implemented-hide:]
config.core.v3.Http3ProtocolOptions http3_protocol_options = 44;

// An optional override that the connection manager will write to the server
Expand Down
3 changes: 3 additions & 0 deletions changelogs/current.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,9 @@ new_features:
change: |
Added :ref:`delay_deny <envoy_v3_api_msg_extensions.filters.network.rbac.v3.RBAC>` to support deny connection after
the configured duration.
- area: http3
change: |
``http3_protocol_options`` in ``HttpConnectionManager`` has been upgraded to general access.
- area: cluster
change: |
Customizing the happy eyeballs algorithm for an upstream cluster by configuring
Expand Down