aws: fix test flake when no IMDS can be found #35633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nigel Brittain <[email protected]>
karanvasnani
approved these changes
Aug 8, 2024
Signed-off-by: Nigel Brittain <[email protected]>
KBaichoo
reviewed
Aug 8, 2024
| @@ -52,6 +52,12 @@ class MetadataFetcherImpl : public MetadataFetcher, | |||
| ASSERT(!request_); | |||
| complete_ = false; | |||
| receiver_ = makeOptRef(receiver); | |||
|
|
|||
| // Stop processing if we are shutting down | |||
| if (cm_.isShutdown()) { | |||
There was a problem hiding this comment.
can we have a test for this?
There was a problem hiding this comment.
test case emulates shutdown, as well as the nullptr that would have crashed it had the fix not been in place
The test case would crash when 169.254.169.254 was not available on the host. Unfortunately, where the code was written and also the CI system has this available, leading to the test success. This crash occurs during envoy shutdown in the test case where there is still a request pending, which is now handled by this fix. I'll write a test case to exercise this scenario. |
Signed-off-by: Nigel Brittain <[email protected]>
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
Commit Message: aws: fix test flake when no IMDS can be found Additional Description: Lack of IMDS (169.254.169.254 address) can cause a race condition and crash during testing due to the shutdown of cluster manager. This scenario should not occur normally, as cluster manager will still exist and the lack of IMDS is handled gracefully. Signed-off-by: Nigel Brittain <[email protected]> Signed-off-by: asingh-g <[email protected]>
dcillera
pushed a commit
to dcillera/envoy-1
that referenced
this pull request
Sep 10, 2024
Commit Message: aws: fix test flake when no IMDS can be found Additional Description: Lack of IMDS (169.254.169.254 address) can cause a race condition and crash during testing due to the shutdown of cluster manager. This scenario should not occur normally, as cluster manager will still exist and the lack of IMDS is handled gracefully. Signed-off-by: Nigel Brittain <[email protected]>
dcillera
pushed a commit
to dcillera/envoy-1
that referenced
this pull request
Sep 10, 2024
Commit Message: aws: fix test flake when no IMDS can be found Additional Description: Lack of IMDS (169.254.169.254 address) can cause a race condition and crash during testing due to the shutdown of cluster manager. This scenario should not occur normally, as cluster manager will still exist and the lack of IMDS is handled gracefully. Signed-off-by: Nigel Brittain <[email protected]> Signed-off-by: Dario Cillerai <[email protected]>
phlax
pushed a commit
that referenced
this pull request
Sep 10, 2024
Commit Message: aws: fix test flake when no IMDS can be found Additional Description: Lack of IMDS (169.254.169.254 address) can cause a race condition and crash during testing due to the shutdown of cluster manager. This scenario should not occur normally, as cluster manager will still exist and the lack of IMDS is handled gracefully. Signed-off-by: Nigel Brittain <[email protected]> Signed-off-by: Dario Cillerai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: aws: fix test flake when no IMDS can be found
Additional Description: Lack of IMDS (169.254.169.254 address) can cause a race condition and crash during testing due to the shutdown of cluster manager. This scenario should not occur normally, as cluster manager will still exist and the lack of IMDS is handled gracefully.
Risk Level: Low
Testing: N/A
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]